Skip to content

[releases/28.x] [Shopify] Skip empty inventory API call when batch size is exact multiple of 250#7215

Merged
onbuyuka merged 1 commit intoreleases/28.xfrom
backport/28.x/empty-inventory-request
Mar 30, 2026
Merged

[releases/28.x] [Shopify] Skip empty inventory API call when batch size is exact multiple of 250#7215
onbuyuka merged 1 commit intoreleases/28.xfrom
backport/28.x/empty-inventory-request

Conversation

@onbuyuka
Copy link
Copy Markdown
Contributor

@onbuyuka onbuyuka commented Mar 18, 2026 •
edited by github-actions bot
Loading

Summary

  • Guard the final ExecuteInventoryGraphQL call in ExportStock with if InputSize > 0 to avoid sending an unnecessary empty request when the number of inventory items is an exact multiple of the 250-item batch size

Fixes AB#625962

🤖 Generated with Claude Code

@onbuyuka @claude
[Shopify] Skip empty inventory API call when batch size is exact mult…
a89643e 
…iple of 250

Guard the final ExecuteInventoryGraphQL call with an InputSize > 0 check
to avoid sending an unnecessary empty request when the number of items
is an exact multiple of the 250-item batch size.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@onbuyuka onbuyuka requested a review from a team as a code owner March 18, 2026 12:15
@onbuyuka onbuyuka changed the title [Shopify] Skip empty inventory API call when batch size is exact multiple of 250 [releases/28.x] [Shopify] Skip empty inventory API call when batch size is exact multiple of 250 Mar 18, 2026
@onbuyuka onbuyuka enabled auto-merge (squash) March 18, 2026 12:17
@github-actions github-actions bot added the AL: Apps (W1) Add-on apps for W1 label Mar 18, 2026
@github-actions github-actions bot added this to the Version 28.1 milestone Mar 18, 2026
@onbuyuka onbuyuka closed this Mar 21, 2026
auto-merge was automatically disabled March 21, 2026 17:46

Pull request was closed

@onbuyuka onbuyuka reopened this Mar 21, 2026
@onbuyuka onbuyuka enabled auto-merge (squash) March 23, 2026 08:08
darjoo
darjoo reviewed Mar 23, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@darjoo darjoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests not needed in the backport?

@onbuyuka
Copy link
Copy Markdown
Contributor Author

onbuyuka commented Mar 24, 2026 •
edited
Loading

Tests not needed in the backport?

not needed since that test case was added only in main as part of a new feature

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 25, 2026

⚠️ Stale Status Check Deleted

The Pull Request Build workflow run for this PR was older than 72 hours and has been deleted.

📋 Why was it deleted?

Status checks that are too old may no longer reflect the current state of the target branch. To ensure this PR is validated against the latest code and passes up-to-date checks, a fresh build is required.

🔄 How to trigger a new status check:

  1. 📤 Push a new commit to the PR branch, or
  2. 🔁 Close and reopen the PR

This will automatically trigger a new Pull Request Build workflow run.

@onbuyuka onbuyuka closed this Mar 25, 2026
auto-merge was automatically disabled March 25, 2026 11:12

Pull request was closed

@onbuyuka onbuyuka reopened this Mar 25, 2026
@onbuyuka onbuyuka enabled auto-merge (squash) March 25, 2026 11:13
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 29, 2026

⚠️ Stale Status Check Deleted

The Pull Request Build workflow run for this PR was older than 72 hours and has been deleted.

📋 Why was it deleted?

Status checks that are too old may no longer reflect the current state of the target branch. To ensure this PR is validated against the latest code and passes up-to-date checks, a fresh build is required.

🔄 How to trigger a new status check:

  1. 📤 Push a new commit to the PR branch, or
  2. 🔁 Close and reopen the PR

This will automatically trigger a new Pull Request Build workflow run.

@onbuyuka onbuyuka closed this Mar 30, 2026
auto-merge was automatically disabled March 30, 2026 07:42

Pull request was closed

@onbuyuka onbuyuka reopened this Mar 30, 2026
@onbuyuka onbuyuka enabled auto-merge (squash) March 30, 2026 07:42
darjoo
darjoo approved these changes Mar 30, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@darjoo darjoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved: version-tagged backport.

@onbuyuka onbuyuka merged commit 53c7bd6 into releases/28.x Mar 30, 2026
74 of 150 checks passed
@onbuyuka onbuyuka deleted the backport/28.x/empty-inventory-request branch March 30, 2026 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Aleyenda Aleyenda Aleyenda approved these changes

@darjoo darjoo darjoo approved these changes

Assignees

No one assigned

Labels

AL: Apps (W1) Add-on apps for W1

Projects

None yet

Milestone

Version 28.1

Development

Successfully merging this pull request may close these issues.

3 participants

@onbuyuka @Aleyenda @darjoo